fix(migrate-template-gen): return early if output is not Fn:GetAtt or…#14137
Merged
abhi7cr merged 1 commit intomigrationsfrom Mar 13, 2025
Merged
fix(migrate-template-gen): return early if output is not Fn:GetAtt or…#14137abhi7cr merged 1 commit intomigrationsfrom
abhi7cr merged 1 commit intomigrationsfrom
Conversation
aws-aemilia
previously approved these changes
Mar 13, 2025
Sanayshah2
dismissed
aws-aemilia’s stale review
Approved from integration tests github account by mistake
Sanayshah2
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
ReforFn::GetAtt. Currently, the resources that are moved over only depend on outputs with these types. So its safe to return early. We can add additional cases if we discover its required during migrationamplifyfolder (Gen2) and move the backup Gen1 folder (.amplify/migration/amplify) toamplifyIssue #, if available
Description of how you validated changes
ran execute and revert command locally, unit tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.